Shorten some code.

johndoknjas · Nov 26, 2024 · d2f48bd · d2f48bd
1 parent e8881c4
commit d2f48bd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 18 deletions.
diff --git a/ui/analyse/src/study/chapterNewForm.ts b/ui/analyse/src/study/chapterNewForm.ts
@@ -320,25 +320,20 @@ export function view(ctrl: StudyChapterNewForm): VNode {
                   attrs: { disabled: gameOrPgn },
                   hook: {
                     insert: vnode => {
-                      // Reselect the default value programmatically:
                       const selectEl = vnode.elm as HTMLSelectElement;
                       selectEl.value = gameOrPgn ? 'standard' : currentChapter.setup.variant.key;
-                      const waitForEditor = () => {
-                        if (ctrl.editor) {
-                          selectEl.dispatchEvent(new Event('change'));
-                        } else {
-                          setTimeout(waitForEditor, 1);
-                        }
-                      };
-                      waitForEditor();
+                      const triggerChange = () =>
+                        ctrl.editor
+                          ? selectEl.dispatchEvent(new Event('change'))
+                          : setTimeout(triggerChange, 1);
+                      triggerChange();
                     },
                   },
                   on: {
-                    change: e => {
+                    change: e =>
                       ctrl.editor?.setRules(
                         lichessRules((e.target as HTMLSelectElement).value as VariantKey),
-                      );
-                    },
+                      ),
                   },
                 },
                 gameOrPgn

diff --git a/ui/editor/src/interfaces.ts b/ui/editor/src/interfaces.ts
@@ -1,12 +1,12 @@
 import type { Rules } from 'chessops/types';
 
 export type CastlingToggle = 'K' | 'Q' | 'k' | 'q';
-
 export const CASTLING_TOGGLES: CastlingToggle[] = ['K', 'Q', 'k', 'q'];
-
 export type CastlingToggles<T> = {
   [side in CastlingToggle]: T;
 };
+export type Redraw = () => void;
+export type Selected = 'pointer' | 'trash' | [Color, Role];
 
 export interface EditorState {
   fen: string;
@@ -15,10 +15,6 @@ export interface EditorState {
   enPassantOptions: string[];
 }
 
-export type Redraw = () => void;
-
-export type Selected = 'pointer' | 'trash' | [Color, Role];
-
 export interface LichessEditor {
   getFen(): FEN;
   setOrientation(o: Color): void;