add image cleanup

johnpierson · Apr 19, 2024 · c5e070b · c5e070b
1 parent b353834
commit c5e070b
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 13 deletions.
diff --git a/_Release/Revit2021/Relay/Relay.dll b/_Release/Revit2021/Relay/Relay.dll
diff --git a/_Release/Revit2022/Relay/Relay.dll b/_Release/Revit2022/Relay/Relay.dll
diff --git a/_Release/Revit2023/Relay/Relay.dll b/_Release/Revit2023/Relay/Relay.dll
diff --git a/_Release/Revit2024/Relay/Relay.dll b/_Release/Revit2024/Relay/Relay.dll
diff --git a/_Release/Revit2025/Relay/Relay.dll b/_Release/Revit2025/Relay/Relay.dll
diff --git a/src/App.cs b/src/App.cs
@@ -13,6 +13,8 @@ class App : IExternalApplication
     {
         public Result OnStartup(UIControlledApplication a)
         {
+            CleanupOldImages();
+
             //set the Revit version for reuse
             Globals.RevitVersion = a.ControlledApplication.VersionNumber;
 
@@ -26,8 +28,6 @@ public Result OnStartup(UIControlledApplication a)
                     var resetRibbon = relayIni.Read("ResetRibbon", "Settings");
                     //it the path is default, read that
                     Globals.BasePath = path.ToLower().Equals("default") ? Globals.ExecutingPath : path;
-
-                    Globals.ResetRibbonOnSync = bool.Parse(resetRibbon);
                 }
                 //you screwed up the path mapping, sorry this tool is using the default then
                 catch (Exception)
@@ -159,5 +159,23 @@ private void ComponentManagerOnUIElementActivated(object sender, UIElementActiva
                 // suppress the error if it happens
             }
         }
+
+        internal void CleanupOldImages()
+        {
+            var relayImages = Directory.GetFiles(Globals.UserTemp, "relayImage*.png");
+
+            foreach (var image in relayImages)
+            {
+                try
+                {
+                    File.Delete(image);
+                }
+                catch (Exception)
+                {
+                    //do nothing
+                }
+
+            }
+        }
     }
 }
diff --git a/src/Command.cs b/src/Command.cs
@@ -17,13 +17,6 @@ public Result Execute(ExternalCommandData commandData, ref string message, Eleme
         {
             UIApplication uiapp = commandData.Application;
 
-#if DEBUG
-            //if (Globals.ResetRibbonOnSync)
-            //{
-            //    RibbonUtils.ClearRibbon();
-            //}
-#endif
-
             RibbonUtils.SyncGraphs(uiapp);
             RibbonUtils.HideUnused();
 

diff --git a/src/Utilities/Globals.cs b/src/Utilities/Globals.cs
@@ -23,10 +23,8 @@ public partial class Globals
 
         public static string CurrentGraphToRun { get; set; } = "";
 
-        public static bool ResetRibbonOnSync { get; set; } = false;
 
         public static Dictionary<string, RibbonItem> RelayButtons = new Dictionary<string, RibbonItem>();
         public static Dictionary<string, List<RibbonItem>> RelayPanels = new Dictionary<string, List<RibbonItem>>();
-
     }
 }
diff --git a/src/Utilities/RibbonUtils.cs b/src/Utilities/RibbonUtils.cs
@@ -49,7 +49,7 @@ public static void AddItems(Autodesk.Revit.UI.RibbonPanel panelToUse, string[] d
                 //trying out using temp icons to enable button hiding and deleting later
                 if (File.Exists(icon32))
                 {
-                    var temp32 = Path.Combine(Globals.UserTemp, $"{Guid.NewGuid().ToString()}.png");
+                    var temp32 = Path.Combine(Globals.UserTemp, $"relayImage{Guid.NewGuid()}.png");
                     File.Copy(icon32, temp32);
                     icon32 = temp32;
                 }
@@ -63,7 +63,7 @@ public static void AddItems(Autodesk.Revit.UI.RibbonPanel panelToUse, string[] d
                 //trying out using temp icons to enable button hiding and deleting later
                 if (File.Exists(icon16))
                 {
-                    var temp16 = Path.Combine(Globals.UserTemp, $"{Guid.NewGuid().ToString()}.png");
+                    var temp16 = Path.Combine(Globals.UserTemp, $"relayImage{Guid.NewGuid()}.png");
                     File.Copy(icon16, temp16);
                     icon16 = temp16;
                 }