Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Poetry and Nox #91

Merged
merged 20 commits into from
May 15, 2022
Merged

Port to Poetry and Nox #91

merged 20 commits into from
May 15, 2022

Conversation

johnthagen
Copy link
Owner

@johnthagen johnthagen commented May 14, 2022 •
edited
Loading

Closes #16

Closes #72

Partially addressed #29 (through third party shim)

TODO

@johnthagen johnthagen added the enhancement New feature or request label May 14, 2022
@johnthagen johnthagen self-assigned this May 14, 2022
drhagen
drhagen approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@drhagen drhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change!

README.md Outdated Show resolved Hide resolved
@johnthagen @drhagen
Update README.md
4c9529b 
Co-authored-by: David Hagen <david@drhagen.com>
@johnthagen johnthagen marked this pull request as ready for review May 15, 2022 10:33
drhagen
drhagen approved these changes May 15, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
johnthagen and others added 4 commits May 15, 2022 13:42
@johnthagen @drhagen
Update Dockerfile
71283d1 
Co-authored-by: David Hagen <david@drhagen.com>
@johnthagen @drhagen
Update README.md
fe76e32 
Co-authored-by: David Hagen <david@drhagen.com>
@johnthagen
Update GitHub Pages CI
9725e0e
@johnthagen
Clarify venv_backend="none" description
ebf8bdf
@johnthagen johnthagen merged commit 15b5c63 into master May 15, 2022
@johnthagen johnthagen deleted the poetry-nox branch May 15, 2022 17:50
@InCogNiTo124
Copy link

Thank you, this is just great!

@johnthagen johnthagen mentioned this pull request May 15, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drhagen drhagen drhagen approved these changes

Assignees

@johnthagen johnthagen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nox integration Poetry integration
3 participants
@johnthagen @InCogNiTo124 @drhagen