Autocorrelation

[wdpozzo]

it seems to be working now. slicing a deque does not work as we thought. also, i extended the nmcmc to 5 times the ACL and all tests on my machine pass. added a warning if nmcmc > maxmcmc

[pep8speaks]

Hello @wdpozzo! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file cpnest/NestedSampling.py:

Line 235:80: E501 line too long (109 > 79 characters)

• In the file cpnest/cpnest.py:

Line 51:80: E501 line too long (82 > 79 characters)
Line 53:80: E501 line too long (108 > 79 characters)
Line 76:1: W293 blank line contains whitespace
Line 79:1: W293 blank line contains whitespace
Line 102:32: E251 unexpected spaces around keyword / parameter equals
Line 102:34: E251 unexpected spaces around keyword / parameter equals
Line 118:9: E265 block comment should start with '# '
Line 163:25: E128 continuation line under-indented for visual indent
Line 163:39: E251 unexpected spaces around keyword / parameter equals
Line 163:41: E251 unexpected spaces around keyword / parameter equals
Line 180:35: E128 continuation line under-indented for visual indent
Line 180:47: E251 unexpected spaces around keyword / parameter equals
Line 180:49: E251 unexpected spaces around keyword / parameter equals
Line 202:35: E128 continuation line under-indented for visual indent
Line 202:47: E251 unexpected spaces around keyword / parameter equals
Line 202:49: E251 unexpected spaces around keyword / parameter equals
Line 234:1: W293 blank line contains whitespace
Line 236:80: E501 line too long (84 > 79 characters)
Line 238:80: E501 line too long (87 > 79 characters)
Line 243:1: W293 blank line contains whitespace
Line 244:24: E225 missing whitespace around operator
Line 246:24: E225 missing whitespace around operator
Line 248:24: E225 missing whitespace around operator
Line 249:29: E251 unexpected spaces around keyword / parameter equals
Line 249:31: E251 unexpected spaces around keyword / parameter equals
Line 324:1: W293 blank line contains whitespace
Line 329:80: E501 line too long (107 > 79 characters)
Line 329:86: E231 missing whitespace after ','
Line 329:99: E251 unexpected spaces around keyword / parameter equals
Line 329:101: E251 unexpected spaces around keyword / parameter equals
Line 330:77: E231 missing whitespace after ','
Line 330:80: E501 line too long (84 > 79 characters)
Line 331:1: W293 blank line contains whitespace
Line 332:80: E501 line too long (80 > 79 characters)
Line 335:1: W293 blank line contains whitespace
Line 339:1: W293 blank line contains whitespace
Line 346:36: E231 missing whitespace after ','
Line 368:21: E221 multiple spaces before operator
Line 371:80: E501 line too long (127 > 79 characters)
Line 371:105: E231 missing whitespace after ','
Line 371:118: E251 unexpected spaces around keyword / parameter equals
Line 371:120: E251 unexpected spaces around keyword / parameter equals
Line 372:77: E231 missing whitespace after ','
Line 372:80: E501 line too long (84 > 79 characters)
Line 373:1: W293 blank line contains whitespace
Line 377:1: W293 blank line contains whitespace
Line 385:36: E231 missing whitespace after ','
Line 387:1: W293 blank line contains whitespace
Line 393:24: E225 missing whitespace around operator
Line 396:26: E225 missing whitespace around operator
Line 398:15: E221 multiple spaces before operator
Line 405:52: E251 unexpected spaces around keyword / parameter equals
Line 405:54: E251 unexpected spaces around keyword / parameter equals
Line 406:45: E251 unexpected spaces around keyword / parameter equals
Line 406:47: E251 unexpected spaces around keyword / parameter equals
Line 406:80: E501 line too long (106 > 79 characters)
Line 407:44: E251 unexpected spaces around keyword / parameter equals
Line 407:46: E251 unexpected spaces around keyword / parameter equals
Line 407:80: E501 line too long (103 > 79 characters)
Line 408:40: E251 unexpected spaces around keyword / parameter equals
Line 408:42: E251 unexpected spaces around keyword / parameter equals
Line 408:67: E231 missing whitespace after ','
Line 408:80: E501 line too long (98 > 79 characters)
Line 413:80: E501 line too long (92 > 79 characters)
Line 415:80: E501 line too long (92 > 79 characters)
Line 416:30: E221 multiple spaces before operator
Line 416:80: E501 line too long (89 > 79 characters)
Line 419:30: E221 multiple spaces before operator
Line 425:67: E231 missing whitespace after ','
Line 425:80: E501 line too long (81 > 79 characters)

• In the file cpnest/nest2pos.py:

Line 7:1: E265 block comment should start with '# '
Line 177:9: E225 missing whitespace around operator
Line 178:8: E225 missing whitespace around operator
Line 179:7: E225 missing whitespace around operator
Line 181:7: E225 missing whitespace around operator
Line 182:7: E225 missing whitespace around operator
Line 183:9: E225 missing whitespace around operator
Line 186:1: E302 expected 2 blank lines, found 1
Line 190:6: E225 missing whitespace around operator
Line 191:6: E225 missing whitespace around operator
Line 193:17: E225 missing whitespace around operator
Line 193:33: E225 missing whitespace around operator
Line 194:10: E225 missing whitespace around operator
Line 195:10: E225 missing whitespace around operator
Line 198:1: E265 block comment should start with '# '
Line 205:80: E501 line too long (89 > 79 characters)

• In the file cpnest/sampler.py:

Line 69:22: E221 multiple spaces before operator
Line 69:22: E251 unexpected spaces around keyword / parameter equals
Line 69:32: E251 unexpected spaces around keyword / parameter equals
Line 70:24: E221 multiple spaces before operator
Line 70:24: E251 unexpected spaces around keyword / parameter equals
Line 70:32: E251 unexpected spaces around keyword / parameter equals
Line 71:25: E221 multiple spaces before operator
Line 71:25: E251 unexpected spaces around keyword / parameter equals
Line 71:32: E251 unexpected spaces around keyword / parameter equals
Line 72:30: E251 unexpected spaces around keyword / parameter equals
Line 72:32: E251 unexpected spaces around keyword / parameter equals
Line 73:26: E221 multiple spaces before operator
Line 73:26: E251 unexpected spaces around keyword / parameter equals
Line 73:32: E251 unexpected spaces around keyword / parameter equals
Line 74:26: E221 multiple spaces before operator
Line 74:26: E251 unexpected spaces around keyword / parameter equals
Line 74:32: E251 unexpected spaces around keyword / parameter equals
Line 75:29: E221 multiple spaces before operator
Line 75:29: E251 unexpected spaces around keyword / parameter equals
Line 75:32: E251 unexpected spaces around keyword / parameter equals
Line 76:25: E221 multiple spaces before operator
Line 76:25: E251 unexpected spaces around keyword / parameter equals
Line 76:32: E251 unexpected spaces around keyword / parameter equals
Line 105:26: E221 multiple spaces before operator
Line 106:21: E221 multiple spaces before operator
Line 106:47: E251 unexpected spaces around keyword / parameter equals
Line 106:49: E251 unexpected spaces around keyword / parameter equals
Line 106:73: E225 missing whitespace around operator
Line 106:80: E501 line too long (136 > 79 characters)
Line 106:95: E261 at least two spaces before inline comment
Line 139:53: E225 missing whitespace around operator
Line 185:80: E501 line too long (84 > 79 characters)
Line 187:29: E231 missing whitespace after ','
Line 188:1: W293 blank line contains whitespace
Line 191:80: E501 line too long (113 > 79 characters)
Line 191:85: E231 missing whitespace after ','
Line 191:105: E231 missing whitespace after ','
Line 192:1: W293 blank line contains whitespace
Line 258:27: E225 missing whitespace around operator
Line 379:1: W293 blank line contains whitespace

• In the file examples/eggbox.py:

Line 9:10: E225 missing whitespace around operator
Line 9:15: E231 missing whitespace after ','
Line 10:11: E225 missing whitespace around operator
Line 10:15: E231 missing whitespace after ','
Line 10:27: E231 missing whitespace after ','
Line 10:30: E231 missing whitespace after ','
Line 10:43: E261 at least two spaces before inline comment
Line 10:43: E262 inline comment should start with '# '
Line 10:80: E501 line too long (89 > 79 characters)
Line 12:1: W293 blank line contains whitespace
Line 13:28: E231 missing whitespace after ','
Line 15:1: W293 blank line contains whitespace
Line 16:23: E231 missing whitespace after ','
Line 17:33: E231 missing whitespace after ','
Line 40:9: E225 missing whitespace around operator
Line 40:25: E231 missing whitespace after ','
Line 40:35: E231 missing whitespace after ','
Line 40:46: E231 missing whitespace after ','
Line 40:57: E231 missing whitespace after ','
Line 40:70: E231 missing whitespace after ','
Line 40:80: E501 line too long (84 > 79 characters)

• In the file examples/test_50d.py:

Line 37:18: E225 missing whitespace around operator
Line 37:80: E501 line too long (107 > 79 characters)

• In the file tests/test_2d.py:

Line 31:18: E225 missing whitespace around operator
Line 31:43: E231 missing whitespace after ','
Line 31:53: E231 missing whitespace after ','
Line 31:64: E231 missing whitespace after ','
Line 31:75: E231 missing whitespace after ','
Line 31:80: E501 line too long (102 > 79 characters)
Line 31:88: E231 missing whitespace after ','

[johnveitch]

The tests are still failing for me. Especially the HalfGaussian but also others some of the time.

[wdpozzo]

mmh... I am not sure why, to be honest. Will try and rewrite things again. I am confused by the fact that the ACL comes out so small (the ACF looks sane, though) and that the logZ calculation fails. Did you spot anything wrong?