-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework #82
base: master
Are you sure you want to change the base?
Conversation
…plemented the slice sampling of the likelihood limited prior
…ble, not seeing much difference
… small or very large parameters
Hello @wdpozzo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-24 10:17:07 UTC |
Hi Walter,
|
Hi John,
What you see is a warning related to unittest, it should not impede the scripts from running. I get the same on mac.
Try maybe the test_50d with d=10, does it run?
I will try to have a look in the next few days, but I am quite swamped...
Cheers
Walter
…________________________________
Da: John Veitch ***@***.***>
Inviato: lunedì 5 luglio 2021 18:18:33
A: johnveitch/cpnest
Cc: Walter Del Pozzo; Mention
Oggetto: Re: [johnveitch/cpnest] Rework (#82)
Hi Walter,
Apologies for the delay. It seems like I can install ray now using python3.9 on ubuntu, but the code fails to run with ray. I'll try to figure out what's going on but I'd encourage you to give it a go on Linux yourself too. The error I see is
2021-07-05 17:14:13,537 ERROR services.py:1281 -- Failed to start the dashboard: Failed to read dashbord log: [Errno 2] No such file or directory: '/tmp/ray/session_2021-07-05_17-14-12_897364_1069779/logs/dashboard.log'
/home/john/.local/lib/python3.9/site-packages/ray/node.py:890: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/ray/session_2021-07-05_17-14-12_897364_1069779/logs/raylet.out' mode='a' encoding='utf-8'>
self.start_raylet(plasma_directory, object_store_memory)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/home/john/.local/lib/python3.9/site-packages/ray/node.py:890: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/ray/session_2021-07-05_17-14-12_897364_1069779/logs/raylet.err' mode='a' encoding='utf-8'>
self.start_raylet(plasma_directory, object_store_memory)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#82 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACXAVTRQMGVEV6RMQPYKUVDTWHLNTANCNFSM4ZHCHSKA>.
|
Hi John,
I am happy with the way the code works with ray. It seems to be stable and, on my machine, passes all tests. I tried to minimise the impact on existing code, but this will break backward compatibility, but mainly through change of arguments, the rest is unaffected.
Cheers
Walter