Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Flow Control UI menu entry #3343

Open
caco3 opened this issue Oct 18, 2024 · 7 comments
Open

Enable Flow Control UI menu entry #3343

caco3 opened this issue Oct 18, 2024 · 7 comments

Comments

@caco3
Copy link
Collaborator

caco3 commented Oct 18, 2024

@Slider0007 can we enable this now?

<!--<li><a href="#" onclick="flow_start()">Start Round</a></li>--> <!-- Needs to be adapted on code side first to ensure proper user feedback -->

It seems the REST entrypoint exists now.

(although I would prefer we return JSON instead of plain text, but that would require a general API refactoring)

@Slider0007
Copy link
Collaborator

No, you cannot enable this without bigger changes in underlaying main flow structure to ensure proper user feedback.

@caco3
Copy link
Collaborator Author

caco3 commented Oct 18, 2024

what is missing?
Currently it already reports if it can be scheduled or not

@Slider0007
Copy link
Collaborator

Slider0007 commented Oct 18, 2024

If I remember right (This feels long time ago, beginning of last year when I proposed the main flow refactoring #2188) it is only working with autostart active, disabling autostart, main flow is not active anymore. It's still the same issue that main flow is bulky and not controlable and therefore quite limited to properly interact with it... This was one of the reasons I forked at this point.

Some references:

It could be that the functionality can be provided partly, but the main benefit to trigger a start if no autostart is active is not possible. If actual reaction and functionality is sufficient for you, feel free to activate it. :-)

@caco3
Copy link
Collaborator Author

caco3 commented Oct 18, 2024

Yes, the code seems still to be that way that it only works if the autostart is enabled.
I would keep it that way for now and just enable the UI entry, since the REST API anyway is available.

As a workaround to work around disabling the autostart, one can just set a very large interval.

Refactoring the whole loop thing is out of scope from my side.

@Slider0007
Copy link
Collaborator

Slider0007 commented Oct 18, 2024

Once it's on the WebUI, hopes will be raised and questions will come, so I didn't activate it at the time. As soon as I use the REST API call, I'm already deeper into the topic and usually also more experienced with software.

Just my cents...

@caco3
Copy link
Collaborator Author

caco3 commented Oct 18, 2024

we also just could disable the disabling option and instead let it set to max. 24h.
disabling it always was marked as a debug option: https://jomjol.github.io/AI-on-the-edge-device-docs/Parameters/#parameter-autostart

IMO there speaks nothing against it to start the round directly at startup, even when we only want to trigger it manually. With a high enough interval there should be no disturbance to manually triggering it.

@Slider0007
Copy link
Collaborator

This could be a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants