Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for translation of holiday names #12

Open
jonasbn opened this issue Jun 6, 2017 · 4 comments
Open

Add support for translation of holiday names #12

jonasbn opened this issue Jun 6, 2017 · 4 comments
Assignees
@jonasbn
Labels
enhancement

Comments

@jonasbn
Copy link
Owner

jonasbn commented Jun 6, 2017

This has been lifted from rt.cpan.org, RT issue: 101366

Date::Holidays->new() doesn't pass along {province=>'BC', language='EN'} to Date::Holidays::CA > or {state=>'NJ'} to Date::Holidays::US (which I'm writing). There is a "TODO" in your source code > that mentions this fact!

We need to support both province and language.
@jonasbn
Copy link
Owner Author

jonasbn commented Jun 6, 2017

See also: RT:106793

@jonasbn jonasbn self-assigned this May 30, 2018
@jonasbn
Copy link
Owner Author

jonasbn commented Jun 14, 2018

I have created a project "Localization and Translation", which will be putting some effort into language.

@jonasbn jonasbn changed the title Address issues with Date::Holidays::CA Add support for translation of holiday names Jun 16, 2018
@jonasbn
Copy link
Owner Author

jonasbn commented Jun 16, 2018 •
edited
Loading

Interesting insight: Date::Holidays::CZ contains translation to English.

@jonasbn jonasbn pinned this issue Oct 9, 2020
@jonasbn
Copy link
Owner Author

jonasbn commented Oct 4, 2022

All of these distributions, support a lang parameters for relevant methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasbn jonasbn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasbn