pkp/pkp-lib#10111 Dropped the reference assignment

jonasraoni · Jun 25, 2024 · 081c3f0 · 081c3f0
1 parent 203d098
commit 081c3f0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/classes/search/MonographSearch.inc.php b/classes/search/MonographSearch.inc.php
@@ -25,9 +25,8 @@ function getSparseArray($unorderedResults, $orderBy, $orderDir, $exclude) {
 		// Calculate a well-ordered (unique) score.
 		$resultCount = count($unorderedResults);
 		$i = 0;
-		foreach ($unorderedResults as $submissionId => &$data) {
-			// Reference is necessary to permit modification
-			$data['score'] = ($resultCount * $data['count']) + $i++;
+		foreach ($unorderedResults as $submissionId => $data) {
+			$data[$submissionId]['score'] = ($resultCount * $data['count']) + $i++;
 		}
 
 		// If we got a primary sort order then apply it and use score as secondary