Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original :octocat: should be attributed to correct author #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonico
Copy link
Owner

@jonico jonico commented Oct 25, 2023

image

The original :octocat: has an author too, even though he does not have a GitHub profile (that's why we missed him in the automatically generated html to JSON conversion by Postbot).

Let's adjust the API tests so that every Octocat is correctly attributed and add Simon Oxley as the original author.

Fun fact: Simon did not only create the original :octocat: but also the Twitter 🐦 and Sammy the 🦈 - Digital Ocean's mascot.

@jonico jonico temporarily deployed to octodex-rest-api-pr-5 October 25, 2023 11:53 Inactive
@jonico jonico temporarily deployed to octodex-rest-api-pr-5 October 25, 2023 11:56 Inactive
@jonico jonico changed the title Original author should be attributed to correct author Original :octocat: should be attributed to correct author Oct 25, 2023
@jonico jonico force-pushed the dont-forget-simon branch from 5db27f3 to e4d9076 Compare November 1, 2023 14:43
@jonico jonico temporarily deployed to octodex-rest-api-pr-5 November 9, 2023 08:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant