Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facing an Issue while assessing M365 #288

Closed
rc-ranjith opened this issue Aug 2, 2024 · 4 comments · Fixed by #291
Closed

Facing an Issue while assessing M365 #288

rc-ranjith opened this issue Aug 2, 2024 · 4 comments · Fixed by #291
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@rc-ranjith
Copy link

About the Issue
I'm facing an issue with auditing my M365. I've added the Client ID, Client Secret, Tenant ID and Tenant Location in the external_providers.toml file as mentioned in the documentation.

image

Any help would be appreciated!!

@rc-ranjith rc-ranjith added bug Something isn't working documentation Improvements or additions to documentation labels Aug 2, 2024
@jonrau1
Copy link
Owner

jonrau1 commented Aug 2, 2024

Thanks for the report. I will have a fix for this soon. It's attempting to use STS to fill in an AWS Account ID but for these non-AWS checks I will hardcode an account ID instead.

@rc-ranjith
Copy link
Author

Thanks for your quick reply, looking forward on the fix 🫡

@jonrau1
Copy link
Owner

jonrau1 commented Aug 2, 2024

@rc-ranjith pushed a change that doesn't use Boto3, since the default format for findings is ASFF/Security Hub I have to put something there.

It's in another branch, here's the commit if you want to try it yourself abb2c92

Also if there are any other M365 checks you'd like me to include feel free to open another Issue. I'll keep this one opened until you confirm it's fixed for you

@jonrau1 jonrau1 self-assigned this Aug 2, 2024
@rc-ranjith
Copy link
Author

@jonrau1 Thanks for the update, I tried the latest commit. Still I'm getting these errors.

SSPM-Issue_2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

2 participants