-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: condition to incorporate *
in regEx to match step-syntax
#51
base: master
Are you sure you want to change the base?
Conversation
fix: condition to incorporate `*` in regEx to match step-syntax
@mohitpubnub thank you for the PR. Could you clarify what this is fixing by giving an example. Please also add a test for this |
…en/when/then/and. add: asterisk in DialectMock to recognise it in test.
@jonsamwell gherkin syntax supports asterisk in feature file (Gherkin Reference) |
@mohitpubnub many thanks for this and your explanation. It is a great change, thanks for providing the PR. As this could have quite sweeping changes could you add the referenced features (See below) as a couple of tests to this full syntax parsing suite (https://github.com/jonsamwell/dart_gherkin/blob/master/test/gherkin/parser_test.dart#L17).
Sorry for being pedantic here I just don't want this change to have unexpected consequences. |
@jonsamwell Now parser recognises line starting with asterisks at dart_gherkin/test/gherkin/parser_test.dart Lines 103 to 113 in 2c6fa8a
I'm not sure, Is this correct scenario for multiline description or need to change test suite content? any thought? |
Also because, |
The condition is making parser to ignore asterisk! And that leads parser to categorise line with
*
as text_line syntax and gives error:Exception: Unknown runnable child given to Scenario 'TextLineRunnable'