Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tentatively) adding testthat for as_api_object -- need to check arguments? #86

Merged
merged 5 commits into from
May 6, 2024
Merged

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    3d6876b View commit details
    Browse the repository at this point in the history
  2. Tweak as_api_object documentation

    I originally wrote this for lists, but it also works for character vectors, and may eventually expand to other objects like data frames. Thanks for catching the mismatch! Hopefully this fix makes as much sense as this can!
    jonthegeek committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    bda5e25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    197d3aa View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    23ffc78 View commit details
    Browse the repository at this point in the history
  2. Update tests to check for as_api_object-specific things.

    Good idea, but the errors were being generated by base R/weren't saying anything useful (they were the general "missing argument" messages). I've updated them to focus on the things as_api_object does specifically, to separate a failure of this function from all the places it's used within the package.
    jonthegeek committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9b07d0f View commit details
    Browse the repository at this point in the history