-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After Effects dockable (panel) wrapper #72
Comments
This has now been added. I decided to trim it down to essentials, so instead of a wrapper, it's just extra code here and there that makes it work as a dockable panel. You can use the function wrapper option together with this one if you want. Few important things:
|
Hi! I'm testing the wrapper right now. I'm finding some hiccups with it: First, it doubles the Panel name: this can be solved by adding an if condition before the defining the dialog.text: But, it's kinda a bummer to add it everytime i update the layout. The other problem is that, when i open the dialog as a scriptUI panel, that doesn't happen when i execute it as a script: I tried to adapt the solution from here: but, i guess it's not possible to fix this issue without wrapping everything inside a function. maybe i broke something in my layout, here it is for reference:
|
@jetrotal, yea the first thing should be super effortless to fix. Just to put it out there, this happens because the dockable panel in AE seems to automatically use the filename in the title, making the window title just like a secondary title. The second thing is something I'll have to look into because I'm not sure how to fix it right now. I think it could be loosely related to a third issue that I just realized was a thing, which is that parent items don't seem to care about the And like you said, both of these sizing related issues happen in the dockable panel only. I don't think any of this will require a lot of work, but all of these things are very specific AE quirks that I have no prior experience with. I just need to investigate it a little... |
I played around a bit more , maybe that has nothing to do with the code you built: It breaks the external panel "permanently" only if I drag the panel to this stack of other panels. I managed to fix it "permanently" again, by My final guess is that you shouldn't worry about this glitch after all. Even the official Adobe panels breaks the same: Maybe @rendertom can help us understanding this issue. |
Issue was that AE's dockable SUI takes the titles from the filename and then this window title becomes a sort of secondary title. If the user would have any reason to use the script as a regular dialog window instead of a dockable panel, make sure the dialog title and the script filename are a match.
@jetrotal, the double title issue should be handled now. I'm still looking into the other issues. |
Yes. Now that you said it, I remember how I forgot to specify that this is for the dialog window only. Well, I'll be fixing it just as fast and loose later today and if we are lucky I won't forget anything this time. |
I've been looking into the sizing quirks and as far as I know, they seem pretty normal behavior. I've never actually written anything past an expression in AE, so I don't know for sure though. The |
Currently the generated dialog can't be docked like native panels in After Effects without manually adding the wrapper. I'm planning to add this as an export option so users don't have to add it themselves...
The text was updated successfully, but these errors were encountered: