-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize buttons makes them squared inside groups #96
Comments
Yea, I don't really know more than you about it... Maybe just that it's something in PS specifically, and maybe certain versions. I'm not certain about localization, just I feel pretty confident that if you tried it in Indesign or Illustrator, all buttons would likely be round. I've definitely seen this happening on Mac... In fact in recent memory that's the only OS's where I've seen this behavior. You could try to see if leaving out the ok and cancel buttons would help. I feel like maybe I've tried it so it probably didn't work cause I can't remember. They have some default behavior but you should be able to replicate that, if needed. Is it a CEP panel? The code made me assume you meant to say SUI? If it is HTML and CSS it sounds like a weird but fixable issue. |
My take on it is that it's their way of lazily defining a primary set of buttons, perhaps so that all old SUI dialogs get the primary button style, and it's probably based on how often times the "primary" buttons are/or sit next to the default Beats me why PS has these differences, especially in CC, which is when they added the round buttons (I think) and quite a few other visual changes... but PS has always been the kind of the Internet Explorer of Script UI for whatever reason. Like for example how When I first bumped into this "buttons with rounded/straight corners" issue I just let it go because it didn't seem worth it to struggle with it since that's how it is in the application preferences and built in scripts as well... Which by the way hint heavily that the "primary" set of buttons should be rounded, I think that's where I got it from.
|
I’ve gotten around it using images as buttons instead of letting them default if you want to change them as you suggested.
…Sent from my iPhone
On Jan 16, 2022, at 10:49 AM, Joonas Pääkkö ***@***.***> wrote:
My take on it is that it's their way of lazily defining a primary set of buttons, probably based on how often the "primary"
buttons are... or sit next to the default ok and cancel buttons. Beats me why PS has these differences, especially in CC, which is when they added the round buttons (I think) and quite a few other visual changes... but PS has always been the kind of Internet Explorer of Script UI for whatever reason. Like for example how Palette window type has been broken for like 10 years I think.
When I first bumped into this "buttons with rounded/straight corners" issue I just let it go because it didn't seem worth it to struggle with it since that's how it is in the application preferences and built in scripts as well... Which by the way hint heavily that the "primary" set of buttons should be rounded, I think that's where I got it from.
I took fresh a look at it, but couldn't come up with any kind of workaround, other than maybe using iconButton with a different image per button, which probably isn't worth it,
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
|
That is indeed great workaround, i could make an very simpe png and make it binary. This will tax the file size quite a lot though :( |
It's going to cause you way less of a headache if you leave it be. Since all PS CC SUI dialogs suffer from the same issue, including application preferences... I don't think anyone is going to care as much as you do right now :) You're going to have heck of a time generating images if you want localization on them... And the filesize... I have no experience with this in SUI, but how would the images show up on high dpi screens... |
I store them locally but agree with you entirely about people caring unless you want specific icons or a look to the interface.
…Sent from my iPhone
On Jan 16, 2022, at 3:35 PM, Joonas Pääkkö ***@***.***> wrote:
It's going to cause you way less of a headache if you leave it be. Since all PS CC SUI dialogs suffer from the same issue, including application preferences... I don't think anyone is going to care as much as you do right now :)
You're going to have heck of a time generating images if you want localization on them... And the filesize... I have no experience with this in SUI, but how would the images show up on high dpi screens...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
|
Im sort of glad it show now only rounded buttons for the main dialog. Still would love to know what triggers that. As like you mentioned the preference dialog of photoshop also shows rounded buttons for the main functions and squared for the tabbed section and its buttons |
My understanding is that PS finds the first occurrence of a button with the
|
Im updating this CEP panel which has many script and a couple dialog windows. Ive started now adding localize to it and notice some weird behavior which i can find in the resources ive found.
The "issue" im seeing is that when buttons have hard-coded text, defined when they are created. Buttons show with round borders. When i use localize and they are placed inside a group, they get squared off in the corners. But when it uses English they show with rounded corners.
Ive got an example script here. Its perhaps hard to test since you need to have Photoshop with different languages installed. Ive installed different languages by copying the packs when you install the app. Some are old so i guess its misses some parts.
Do you perhaps have knowledge of this?
I see this happening on Windows by the way, OSX doesnt show this.
Ive looked in the Javscript toolguide, the ScriptUI for dummies by Peter Kahrel, tried PS-Script.com (nothing found yet)
The text was updated successfully, but these errors were encountered: