Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

[nightly] When compiling with +nightly one symbol is not found. #1599

Open
keltia opened this issue Dec 28, 2023 · 1 comment
Open

[nightly] When compiling with +nightly one symbol is not found. #1599

keltia opened this issue Dec 28, 2023 · 1 comment

Comments

@keltia
Copy link

keltia commented Dec 28, 2023

When compiling arrow2 with the simd feature and under +nightly, one symbol is not found:

v1.77.0-nightly here.

error[E0432]: unresolved import `std::simd::SimdPartialEq`
 --> /Users/roberto/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow2-0.17.4/src/types/simd/packed.rs:4:5
  |
4 |     SimdPartialEq,
  |     ^^^^^^^^^^^^^ no `SimdPartialEq` in `simd`
  |
  = help: consider importing one of these items instead:
          core::simd::prelude::SimdPartialEq
          std::simd::prelude::SimdPartialEq

So in src/types/simd/packed.rs, SimdPartialEq ought to be written as prelude::SimdPartialEq on line 4 (use).

@keltia
Copy link
Author

keltia commented Dec 29, 2023

I see this is a change that occurred in Rust after June, 2023 so your fixing nightly at this date works around this. So I guess it would be an incompatible change at this time. Still, while it makes sense for you, it will break for all other users so you might want to fix it. I wont submit a PR for this, change is trivial.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant