Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix: More types supports cast to LargeList #1567

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

reswqa
Copy link
Contributor

@reswqa reswqa commented Sep 9, 2023

More types(e.g. LargeUtf8) should also supports cast to LargeList. The only special branch is LargeBinary to LargeList.

@reswqa reswqa changed the title fix: More types supports cast to LargeList [WIP] fix: More types supports cast to LargeList Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (fb7b5fe) 83.06% compared to head (eabcbf9) 83.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   83.06%   83.06%   -0.01%     
==========================================
  Files         391      391              
  Lines       42889    42890       +1     
==========================================
  Hits        35626    35626              
- Misses       7263     7264       +1     
Files Changed Coverage Δ
src/compute/cast/mod.rs 90.84% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reswqa reswqa changed the title [WIP] fix: More types supports cast to LargeList fix: More types supports cast to LargeList Sep 9, 2023
@reswqa
Copy link
Contributor Author

reswqa commented Sep 9, 2023

Seems that CI is unstable, but I assume it's not related to this change.

@ritchie46 ritchie46 merged commit 7c93e35 into jorgecarleitao:main Sep 11, 2023
21 of 25 checks passed
@ritchie46
Copy link
Collaborator

Great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants