This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add a "contains" fast-path to like_utf8_scalar
#1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds dependency on `memchr` when `compute_like` is enabled * When the scalar `rhs` in `a_like_utf8_scalar` starts and ends with a wildcard, and has no other wildcard characters, a fast path using `memchr`'s `Finder` is used. * Added tests that trigger the fast path * Added a benchmark for measuring the performance of the new fast path
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
Coverage 83.38% 83.39%
=======================================
Files 391 391
Lines 42983 42993 +10
=======================================
+ Hits 35841 35853 +12
+ Misses 7142 7140 -2
☔ View full report in Codecov by Sentry. |
sundy-li
approved these changes
Oct 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
memchrto add a fast path tolike_utf8_scalarfor when the pattern can be processed as a "contains" query. For example, if the pattern is%ABBA%, then we can check to see if each string containsABBAinstead of building a regular expression.To measure the performance improvement from this fast path, I added a benchmark. Here are the results on my machine:
Since
memchrdoes the state-of-the-art SIMD tricks (as far as I know), this technique should even be faster for "contains" queries than the glob-matching suggestion in #1295 .