Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forcing non-endemic to be singletons and new vignette on use and limits #45

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

joshwlambert
Copy link
Owner

This PR addresses #36 by adding new functionality to extract_island_species(), with the new argument force_nonendemic_singleton. This allows non-endemic species that would have previously been grouped as an endemic clade if the ancestral state reconstruction inferred their ancestral node to be on the island, to be force to be separate island colonists.

This new functionality comes with complexity and nuance so we have drafted a new package vignette outlining the problem the new functionality aims to solve as well as the known limitations of this approach.

All of this work was done collaboratively with @luislvalente during the Naturalis Hackathon 2024.

@joshwlambert joshwlambert added the enhancement New feature or request label Dec 11, 2024
Copy link
Collaborator

@luislvalente luislvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@luislvalente luislvalente merged commit 7fb42d8 into master Dec 12, 2024
6 checks passed
@joshwlambert joshwlambert deleted the force-nonendemic branch December 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants