Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omidekz/contrib on tortoise orm #260

Closed
wants to merge 9 commits into from

Conversation

omidekz
Copy link

@omidekz omidekz commented Aug 15, 2023

Hi, dears.

modified

  • .gitignore: ignore venv folder to ignore pip packages

create

  • contrib.tortoise.view to extend the BaseModelView based on the tortoise-orm BaseModel
    • add from_model(cls, model: TortoiseBaseModel) classmethod to my view to create the modelview dynamically
  • contrib.tortoise.types to keep diff types in it
  • contrib.tortoise.utils to share logics

@omidekz omidekz closed this Aug 15, 2023
@jowilf
Copy link
Owner

jowilf commented Aug 15, 2023

Hi,
Thank you for taking the initiative to contribute to this project.
I left a more detailed review on this pull request with some suggestions on how the implementation can be improved -> #185 (review)

As you noticed, the contribution docs don't go into much detail there yet. For now, looking at how SQLAlchemy is integrated will provide a good template.
Thank you again for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants