-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add spanish translation for /tutorial #53
base: main
Are you sure you want to change the base?
Conversation
rafnixg
commented
Dec 14, 2022
- ADD: spanish translation for getting-started
- ADD: spanish translation for configurations
- ADD: spanish translation for validations
- ADD: spanish translation for authentication
- ADD: spanish translation for files
- ADD: spanish translation for batch actions
- ADD: spanish translation for multiple-admin
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 3880 3880
=========================================
Hits 3880 3880 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hello @rafnixg, But I'm also thinking about a better solution to update the translated documentation to follow the main doc. Do you have any suggestion ? |
@@ -1,19 +1,16 @@ | |||
# Authentication & Authorization | |||
# Autorización de autenticación |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is out of date
@@ -1,11 +1,10 @@ | |||
# ModelView Configurations | |||
# Configuraciones de ModelView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rafnixg,
Thank you for your work, i made some few comments can you check them ?
Also i notice that mkdocs-static-i18n didn't works well with some mkdocs plugins.
For example, this is what we have in english documentation,
and this is what we have in spanish documentation
This can be a real problem in long term basic, we could be blocked by mkdocs-static-i18n when mkdocs-material release a new version.
Take a look at this -> squidfunk/mkdocs-material#2346
@jowilf Edit: I'm also translating FastAPI Documentation, it's structure is neat. but a bit of complex, I would recommend checking it. |
This PR is quite old and outdated. None of the requested changes are satisfied. @rafnixg are you planning to work on this? |
I would indeed be interested in supporting the translation, but it wasn't clear to me what the mechanism or the way to proceed would be. You mentioned that mkdocs-static-i18n had issues with other plugins; has this been resolved? I would like to be able to translate and disseminate content in Spanish. |
Happy to see you are still interested in it, I thought this PR was abandoned because you haven't said anything since December 2022. I wanted your attention. 🤫 As far as I know, @jowilf is planning to resolve the issue but it's not there yet. I'm sure the author, seeing two such enthusiastic people in the translation process, you and me, will be motivated to resolve the issue. Note: I sure tried to resolve the issue myself but couldn't. |