This repository has been archived by the owner on Oct 3, 2018. It is now read-only.
Fixes #154: cannot render emoji inside a table #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| classesBlacklist = new RegExp(defaultConfig.blacklist.classes.join('|'), 'i'); | ||
|
|
||
| if(typeof win.document.createTreeWalker !== 'undefined') { | ||
| var nodeIterator = win.document.createTreeWalker( | ||
| el, | ||
| win.NodeFilter.SHOW_TEXT | win.NodeFilter.SHOW_ELEMENT, | ||
| function(node) { | ||
| if(node.nodeType !== 1) { | ||
| if(node.nodeType !== node.ELEMENT_NODE) { | ||
| /* Text Node? Good! */ |
There was a problem hiding this comment.
Does this comment still make sense?
|
This should be merged, especially the current blacklist matches any tag with an |
schmunk42
added a commit
to dmstr/yii2-emojifyjs-asset
that referenced
this pull request
Mar 6, 2017
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default black list,
node.tagName.match(elementsBlacklist)returnedArray['A']for atableelement.Now it returns
null, the correct answer.Another modification, I used the constant
node.ELEMENT_NODEfrom MDN.