Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatible way of importing reverse #35

Closed
wants to merge 4 commits into from

Conversation

svleeuwen
Copy link

Makes this library compatible with Django 1.10+

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 43.902% when pulling 0c0b302 on svleeuwen:master into 075886b on jp74:master.

@coveralls
Copy link

coveralls commented Apr 21, 2019

Coverage Status

Coverage increased (+0.3%) to 43.902% when pulling 15a3aaf on svleeuwen:master into 075886b on jp74:master.

@bashu
Copy link
Contributor

bashu commented Apr 21, 2019

@svleeuwen I don't have access to the repo anymore, can not help here...

@Asday
Copy link

Asday commented Apr 21, 2019

Who removed you, @bashu? I don't see any reason to revoke the access given to you in #29.

@bashu
Copy link
Contributor

bashu commented Apr 21, 2019

@Asday I can not merge this PR

@Asday
Copy link

Asday commented Apr 21, 2019

Appreciated, but do you have any notification or having your access revoked?

@bashu
Copy link
Contributor

bashu commented Apr 26, 2019

@Asday don't know

This way we can send alternative kwargs we may need during save.
@Asday
Copy link

Asday commented Jun 16, 2019

@sanderl-mediamonks That last commit has nothing to do with this PR.

@svleeuwen
Copy link
Author

@Asday Right, this PR shouldn't have come from my master anyway. I think the best approach would be to remove this PR and create a new one.

@svleeuwen
Copy link
Author

Close in favor of #36

@svleeuwen svleeuwen closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants