Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native module compilation errors #47

Open
jpillora opened this issue Oct 21, 2014 · 3 comments
Open

Native module compilation errors #47

jpillora opened this issue Oct 21, 2014 · 3 comments
Labels

Comments

@jpillora
Copy link
Owner

Bug: Had reports via email recounting native module compilation errors due to node-expat, which is used by the current XML parser. If this is a big issue, we can apply @ubik2's patch https://gist.github.com/ubik2/95d18f849b7b2878e4e0.

@jpillora jpillora mentioned this issue Oct 21, 2014
@jpillora jpillora added the bug label Oct 21, 2014
@mderazon
Copy link

Compilation warnings looks scary indeed but are probably not a big deal.

Couple of thoughts regarding xml parsing:

  1. Doesn't Google Sheet provide json api as well ?
  2. Maybe switch to https://github.com/Leonidas-from-XIV/node-xml2js which looks more maintained anyway. Looks like it has more or less same features set as the current xml parser, but I don't know how difficult it will be to switch.

@jpillora
Copy link
Owner Author

  1. JSON results though errors are still XML which means we'll need an XML
    parser anyway
  2. I think we chose the native one because it had higher performance though
    maybe the module you referenced is fast enough?

On Thursday, February 26, 2015, Michael Derazon notifications@github.com
wrote:

compilation warnings looks scary indeed but are probably not a big deal
xmppo/node-expat#58.

Couple of thoughts regarding xml parsing

  1. Doesn't Google Sheet provide json api as well ?
  2. Maybe switch to https://github.com/Leonidas-from-XIV/node-xml2js which
    looks more maintained anyway. Looks like it has more or less same features
    set as the current xml parser, but I don't know how difficult it will be to
    switch.


Reply to this email directly or view it on GitHub
#47 (comment)
.

@Exlipse7
Copy link

I tried installing this module and xml2json is failing in npm. This is due to dependence on node-expat which is listed as build-error on the npm site. Also, node-expat depends on node-iconv, which depends on node-gyp, which is miserable to install on windows machines as it requires specific versions of Python and Visual Studio to be installed. In reference to the above note on node-xml2js, I've used it before with no problem, but it's been several months so I'm not sure on it's current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants