Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing CLI tests #1933

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Added missing CLI tests #1933

merged 3 commits into from
Aug 29, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Adds the missing tests from #179

@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox and removed request for tsaglam August 22, 2024 13:45
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Aug 26, 2024
tsaglam
tsaglam requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing. Can you also look at the sonar issues?

cli/src/test/java/de/jplag/cli/ExcludeFileTest.java Outdated Show resolved Hide resolved
tsaglam
tsaglam reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the visibility issues raised by sonar?
EDIT: Ah I think you just did.

@TwoOfTwelve
Copy link
Contributor Author

Yeah, sorry. I've just seen your original comment.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit fb9ab93 into develop Aug 29, 2024
44 checks passed
@tsaglam tsaglam deleted the feature/cliTests branch August 29, 2024 10:54
@tsaglam tsaglam mentioned this pull request Oct 25, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@Kr0nox Kr0nox Awaiting requested review from Kr0nox

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoOfTwelve @tsaglam