Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate go enrichment improvement #276

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

jpquast
Copy link
Owner

@jpquast jpquast commented Oct 29, 2024

Adds a new argument to calculate_go_enrichment() and also fixes a bug with provided factor columns.

@jpquast jpquast added bug Something isn't working enhancement New feature or request labels Oct 29, 2024
@elena-krismer
Copy link
Collaborator

Rplot

@elena-krismer
Copy link
Collaborator

when plotting the barplot the label_size is shown in the legend (which i guess shouldnt be there)

@elena-krismer
Copy link
Collaborator

Further I would consider to create the label name when creating the input data, so its accessible from the dataproperty of the plot

paste0(
                .data$n_significant_proteins_in_process,
                "/",
                .data$n_detected_proteins_in_process,
                "(",
                round(.data$n_significant_proteins_in_process / .data$n_detected_proteins_in_process * 100, digits = 1),
                "%)"
              ),

This would allow to adjust the labels after plotting

plot +  geom_text(aes(label = labels), size = 5)

Copy link
Collaborator

@elena-krismer elena-krismer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good despite the label/pt in the barplot legend

@jpquast
Copy link
Owner Author

jpquast commented Oct 30, 2024

I think you might not have been in the newest commit since I had already fixed the legend issue.
Thanks for the suggestion regarding adding the label to the data. It is now implemented.

@jpquast jpquast merged commit fb2bd6c into developer Oct 31, 2024
5 of 6 checks passed
@jpquast jpquast deleted the calculate_go_enrichment-improvement branch October 31, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants