Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor outputFile APi in async/await #1024

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Oct 21, 2023

The PR is a part of the proposal #1020.

All test cases pass: https://github.com/SukkaW/node-fs-extra/actions/runs/6599334843.

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one stupid variable name from the old code

lib/output-file/index.js Outdated Show resolved Hide resolved
lib/output-file/index.js Outdated Show resolved Hide resolved
@RyanZim RyanZim merged commit 426bb46 into jprichardson:master Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants