Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add support for "module" link on QUnit pages #108

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Nov 4, 2024

First released with QUnit 3.0.0-alpha.4.

Test plan:

  • module key is set in cdn.json data for QUnit 3.0.0-alpha.4, not for older releases.
  • module link is included on qunit.html for QUnit 3.0.0-alpha.4, not for other releases.
$ npm install && npx grunt build

$ less dist/wordpress/resources/cdn.json
$ less dist/wordpress/posts/page/qunit.html
  "qunit": {
    "latestStable": {
      "filename": "qunit/qunit-2.22.0.js",
      "version": "2.22.0",
      "theme": "qunit/qunit-2.22.0.css"
    },
    "all": [
      {
        "filename": "qunit/qunit-3.0.0-alpha.4.js",
        "version": "3.0.0-alpha.4",
        "theme": "qunit/qunit-3.0.0-alpha.4.css",
        "module": "qunit/qunit-3.0.0-alpha.4.module.js"
      },
      {
        "filename": "qunit/qunit-3.0.0-alpha.3.js",
        "version": "3.0.0-alpha.3",
        "theme": "qunit/qunit-3.0.0-alpha.3.css"
      },
<h2>QUnit - All Versions</h2>
<ul>
	<li>
	QUnit 3.0.0-alpha.4 -
	<a
			class='open-sri-modal'
			href='https://code.jquery.com/qunit/qunit-3.0.0-alpha.4.js'
			data-hash='sha256-VKxoHCY02QAnjeQaJ+xYA/kfZTAlzN6n8qP+SDvVI7Y='
		>script</a>,
	<a
			class='open-sri-modal'
			href='https://code.jquery.com/qunit/qunit-3.0.0-alpha.4.module.js'
			data-hash='sha256-XHulKlQYLHGDuBSpNK5BBykG1VB15lfYHlx3iF0nan0='
		>module</a>,
	<a href='https://code.jquery.com/qunit/qunit-3.0.0-alpha.4.css'>stylesheet</a>
</li>
<li>
	QUnit 3.0.0-alpha.3 -
	<a
			class='open-sri-modal'
			href='https://code.jquery.com/qunit/qunit-3.0.0-alpha.3.js'
			data-hash='sha256-cgHZe4kjOb6ZUMVxlAKMr7f5+0CqPxl6GzN32diU2n4='
		>script</a>,
	<a href='https://code.jquery.com/qunit/qunit-3.0.0-alpha.3.css'>stylesheet</a>
</li><li>
	QUnit 2.22.0 -
	<a
			class='open-sri-modal'
			href='https://code.jquery.com/qunit/qunit-2.22.0.js'
			data-hash='sha256-N4+2khEOiYS4o7WwvBQl0xZlAddyqQYVq5NBnUdugig='
		>script</a>,
	<a href='https://code.jquery.com/qunit/qunit-2.22.0.css'>stylesheet</a>
</li>

Ref qunitjs/qunit#1798.
Ref qunitjs/qunit#1551.

@Krinkle Krinkle merged commit 983eb63 into main Nov 4, 2024
1 check passed
@Krinkle Krinkle deleted the qunit-module branch November 4, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant