Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (some) linter findings #190

Merged
merged 23 commits into from
Aug 23, 2024
Merged

Fix (some) linter findings #190

merged 23 commits into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. chore(lint): configure make lint target to use .localci/lint/golangci… 

    ….yml
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    20dac5d View commit details
    Browse the repository at this point in the history

  2. fix(lint/copylocks): assignment copies lock value

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    839eeae View commit details
    Browse the repository at this point in the history

  3. fix(lint/staticcheck): should not use built-in type string as key for… 

    … context value
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    57e6e3e View commit details
    Browse the repository at this point in the history

  4. fix(lint/staticcheck): printf-style function with dynamic format stri… 

    …ng and no further arguments should use print-style function instead
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4283896 View commit details
    Browse the repository at this point in the history

  5. fix(lint/staticcheck): this value of is never used

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    37d1982 View commit details
    Browse the repository at this point in the history

  6. fix(lint/gosimple): should omit nil check; len() for []byte is define… 

    …d as zero
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3a01dfe View commit details
    Browse the repository at this point in the history

  7. fix(lint/gosimple): should use b.Bytes() instead of []byte(b.String())

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0d5b435 View commit details
    Browse the repository at this point in the history

  8. fix(lint/gosimple): should merge variable declaration with assignment… 

    … on next line
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e01033d View commit details
    Browse the repository at this point in the history

  9. fix(lint/gosimple): unnecessary assignment to the blank identifier

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6fd0b01 View commit details
    Browse the repository at this point in the history

  10. fix(lint/errcheck): error return value not checked

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7e923d4 View commit details
    Browse the repository at this point in the history

  11. fix(lint/copyloopvar): the copy of the 'for' variable can be deleted … 

    …(Go 1.22+)
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d609078 View commit details
    Browse the repository at this point in the history

  12. fix(lint/unconvert): unnecessary conversion

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    14a4e3a View commit details
    Browse the repository at this point in the history

  13. fix(lint/revive): fix exported type to remove package prefix duplication

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3a95afd View commit details
    Browse the repository at this point in the history

  14. fix(lint/revive): if block ends with a return statement, so drop this… 

    … else and outdent its block
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    11404cd View commit details
    Browse the repository at this point in the history

  15. fix(lint/revive): if block ends with call to os.Exit function, so dro… 

    …p this else and outdent its block
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    73c9a8f View commit details
    Browse the repository at this point in the history

  16. fix(lint/wastedassign): assigned but reassigned without using the value

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    01f4d79 View commit details
    Browse the repository at this point in the history

  17. fix(lint/stylecheck): should use constant http.StatusMovedPermanently… 

    … instead of numeric literal 301
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    01c1e4f View commit details
    Browse the repository at this point in the history

  18. fix(lint/contextcheck): functions should pass the context parameter

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    98305a2 View commit details
    Browse the repository at this point in the history

  19. fix(lint/gosec): slice index out of range

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3efaa4a View commit details
    Browse the repository at this point in the history

  20. fix(lint/nestif): complex nested blocks

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d2377c5 View commit details
    Browse the repository at this point in the history

  21. fix(lint/gosec): use of net/http serve function that has no support f… 

    …or setting timeouts
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    eee0cc5 View commit details
    Browse the repository at this point in the history

  22. fix(lint/gocritic): rewrite if-else to switch statement

    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9e8a907 View commit details
    Browse the repository at this point in the history

  23. fix(lint/revive): don't use MixedCaps in package name; mongoDB should… 

    … be mongodb
    @lburgazzoli
    lburgazzoli committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    81ccde1 View commit details
    Browse the repository at this point in the history