Add DSL support for named streams. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to declare streams and fields for bolts and streams inside of the Topology definition.
Fixes an issue where outfields that are defined in the Spout or Bolt are not recognized by the Nimbus server when it validates the existence of streams for all bolts in the topology.
Not all bolts defined in a topology inherit from the RedStorm::DSL. This ensures the output fields in the ComponentDefinition are only copied if the class uses the OutputFields module. Also, redefining field names for the default stream will replace any previously defined default field names.
…nt/redstorm Conflicts: Gemfile.lock lib/red_storm/dsl/bolt.rb lib/red_storm/dsl/spout.rb redstorm.gemspec
rtyler
pushed a commit
that referenced
this pull request
Aug 27, 2015
Add DSL support for named streams.
|
@cattywampus @robbavey FYI, I'm going to play around with this a bit and I'll probably tag a release which will be published to bintray today or tomorrow |
|
@robbavey this is now in redstorm 0.8.0 available in jcenter |
|
Nice! Thanks @rtyler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of the Pull Request (colinsurprenant#129) adding DSL support for named streams to Redstorm. The link above gives a detailed explanation of this PR.