completed the task UiStretch #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
ShGKme
requested changes
Oct 7, 2024
04-sfc/30-UiStretch/UiStretch.vue
Outdated
Comment on lines
15
to
17
| :deep(.stretch-container > img), | ||
| :deep(.stretch-container > video), | ||
| :deep(.stretch-container > picture) { |
There was a problem hiding this comment.
Такое решение работает. Но, если в содержимое компонента даже где-то глубоко-глубоко случайно тоже будет элемент попадающий под .stretch-container > img - на него эти стили тоже подействуют.
Нужно немного поправить селектор так, чтобы он действовал только и только на img/video являющиеся непосредственно дочерними для дива этого компонента.
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
|
Если :deep применить только к самим img/video, а не полностью всё оборачивать |
ShGKme
approved these changes
Oct 13, 2024
Comment on lines
+15
to
+17
| .stretch-container > :deep(img), | ||
| .stretch-container > :deep(video), | ||
| .stretch-container > :deep(picture) { |
There was a problem hiding this comment.
Хотя deep с > работает точно также, лучше здесь использовать :slotted. Семантически - стилизуется именно содержимое слота.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Правильное ли такое решение?