Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add husky to execute prettiere / eslint on commit / push #17

Open
dawehner opened this issue Nov 2, 2019 · 0 comments
Open

Add husky to execute prettiere / eslint on commit / push #17

dawehner opened this issue Nov 2, 2019 · 0 comments

Comments

@dawehner
Copy link
Contributor

dawehner commented Nov 2, 2019

It would be nice as a contributor to not have to remember executing eslint/prettier locally or wait for the tests to pass on github.

Idea

  1. Run prettier on commit
  2. Run eslint and tests (unit tests) on push

This way you can not create a PR, unless you fix those problems.
You can always bypass this using --no-verify on commits and PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dawehner