Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_common/jsk_robot_startup/util/start_launch_sound.py] PLAY_START -> PLAY_ONCE #631

Merged
merged 2 commits into from
Jul 11, 2016

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Jul 1, 2016

PLAY_START means starting repeating.
Current codes in sound_play does not support repeating, so it plays only once at now.
I fixed the upstream, so this code should also be fixed.
ros-drivers/audio_common#77

@furushchev
Copy link
Member Author

@k-okada Please merge if there is no problem.

@k-okada k-okada merged commit 64619b9 into jsk-ros-pkg:master Jul 11, 2016
furushchev pushed a commit to furushchev/jsk_robot that referenced this pull request Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants