Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast schemaform.error.* broken #993

Open
pvbrakel opened this issue Jan 25, 2019 · 0 comments
Open

Broadcast schemaform.error.* broken #993

pvbrakel opened this issue Jan 25, 2019 · 0 comments

Comments

@pvbrakel
Copy link

Found while upgrading to 0.8.14

Our broadcast of error messages does not work any more.

I leave formname undefined and specify a validity as true or false.
$scope.$broadcast('schemaForm.error.' + fieldCode, 'payrollValidation', element.message, isValid)

The following line overwrites the given formname and assigns it the validity (bool) value.

Later on the formname is checked and if it does not match (which it doesn't because is it true|false) the method returns and does nothing.

if (formName != undefined && scope.ngModel.$$parentForm.$name !== formName) {

Is this a bug or am I using it wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants