Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 8.5. #113

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Upgrade Gradle to 8.5. #113

merged 10 commits into from
Dec 4, 2023

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Nov 28, 2023

No description provided.

@netdpb netdpb requested a review from cpovirk November 28, 2023 19:48
@netdpb
Copy link
Collaborator Author

netdpb commented Nov 28, 2023

Trying to figure out why the build is breaking.

@netdpb
Copy link
Collaborator Author

netdpb commented Nov 28, 2023

Can't break it locally. Trying to add --stacktrace here.

@netdpb
Copy link
Collaborator Author

netdpb commented Nov 28, 2023

I give up.

@wmdietl
Copy link
Collaborator

wmdietl commented Nov 29, 2023

@netdpb The CI failure looks like something goes wrong with annotation-tools.
Maybe these two help: jspecify/checker-framework#40 and jspecify/checker-framework#41
It works for me locally :-)

@netdpb
Copy link
Collaborator Author

netdpb commented Nov 29, 2023

It works for me locally too, even without those.

Yes, it's an issue with annotation-tools, which also uses an old Gradle. I think we should give up on this until you've finished deforking. Then we will be able to depend on a released version of annotation-tools (and eisop), right?

@netdpb netdpb marked this pull request as draft November 29, 2023 15:36
@wmdietl
Copy link
Collaborator

wmdietl commented Nov 29, 2023

eisop doesn't depend on annotation-tools. Merging the two checker-framework PRs should unblock this PR and wouldn't make deforking harder.

@netdpb
Copy link
Collaborator Author

netdpb commented Nov 30, 2023

Oh cool! I commented on some Gradle and shell bits of the first one.

@netdpb netdpb changed the title Upgrade Gradle to 8.4. Upgrade Gradle to 8.5. Dec 4, 2023
@netdpb netdpb marked this pull request as ready for review December 4, 2023 19:04
@netdpb netdpb marked this pull request as draft December 4, 2023 19:06
@netdpb netdpb marked this pull request as ready for review December 4, 2023 19:33
@netdpb netdpb requested a review from cpovirk December 4, 2023 19:33
@netdpb netdpb merged commit 7fc5ec8 into jspecify:main Dec 4, 2023
2 checks passed
@netdpb netdpb deleted the gradle-version branch December 4, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants