Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.12 #215

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Update to Gradle 8.12 #215

merged 3 commits into from
Dec 26, 2024

Conversation

wmdietl
Copy link
Collaborator

@wmdietl wmdietl commented Dec 22, 2024

No description provided.

@@ -109,6 +109,12 @@ if (jspecify != null) {
assemble.dependsOn(jspecify.task(':assemble'))
}

// Enable exec/javaexec
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for suggestions for how to do this in a nicer way... The upgrade instructions didn't really help me a lot.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly but unsurprisingly, I'm clueless. Now that I know to look for ExecOperations, I see gradle/gradle#30822, which seems encouraging, I think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here I was doing the right (oddly verbose) thing but in settings.gradle I wasn't actually executing the task. Now it both compiles and seems to do the right thing.

Copy link
Collaborator

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@@ -109,6 +109,12 @@ if (jspecify != null) {
assemble.dependsOn(jspecify.task(':assemble'))
}

// Enable exec/javaexec
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly but unsurprisingly, I'm clueless. Now that I know to look for ExecOperations, I see gradle/gradle#30822, which seems encouraging, I think?

@wmdietl wmdietl merged commit 9cc6b0e into main-eisop Dec 26, 2024
2 of 4 checks passed
@wmdietl wmdietl deleted the gradle-8.12 branch December 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants