Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest @jspm/generator and drop the freeze option from the cli #2561

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

JayaKrishnaNamburu
Copy link
Member

In the latest version of generators. the freeze option in generator is deprecated.
So, we need to reflect the same in the cli. And may be add in future if needed
https://github.com/jspm/generator/releases/tag/2.0.0

Copy link
Member

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the test, can we mark it as freeze.test.skip.ts or similar to get it to be omitted?

@JayaKrishnaNamburu
Copy link
Member Author

@guybedford added the freeze file back. And changed the file name. Can you review once again if everything is good please 😄

@guybedford
Copy link
Member

guybedford commented Dec 22, 2023 via email

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 381a167 into main Dec 22, 2023
4 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the chore/update-jspm-generator-2.0.2 branch December 22, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants