-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow struct slice and struct array for valueType #70
Conversation
that's not what we agreed to. We agreed that Your change breaks the backward compatibility which is unacceptable |
Does playground: |
Do you agree with reimplementing |
Yea, that's what we discussed in the issue |
I updated at 6a7ba1b. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 8 8
Lines 1040 1044 +4
=======================================
+ Hits 1014 1018 +4
Misses 16 16
Partials 10 10 ☔ View full report in Codecov by Sentry. |
LGTM |
Description
Allow struct slices and struct arrays for
valueType
(includingHeader
andenc.EncodeHeader
). However, this does not apply to two-dimensional arrays, etc.Fixes #69
Checklist