Settings #18
Open
Settings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from [`settings` branch](jtauber@cf393b8) by James Tauber.
Extracted - with amendments and integrations - from `settings` branch by James Tauber: * Settings initialization: * Commit ["beginnings of settings capability"](jtauber@cf393b8); * Commit ["support for strength setting"](jtauber@fb87e92). * Documentation: * Commit ["initial settings documentation"](jtauber@8bd6a8c). * `normalization` setting: * Commit "support for normalization setting"](jtauber@6187dd5). Normalization test taken from UCA 5.2.0 conformance tests: ``` CollationTest/5.2.0/CollationTest_NON_IGNORABLE.txt:312:0332 0334; # ... ```
Extracted - with minor amendments in tests - from `settings` branch by James Tauber: * Code: * Commit ["support for strength setting"](jtauber@fb87e92). * Documentation: * Commit ["initial settings documentation"](jtauber@8bd6a8c). ---- Wrt the amended tests: According to [the algorithm for computing the sort key](https://www.unicode.org/reports/tr10/tr10-36.html#Step_3), the sort key does not have to end with a level separator. See also the following examples: * https://www.unicode.org/reports/tr10/tr10-36.html#Array_To_Sort_Key_Table * https://www.unicode.org/reports/tr10/tr10-36.html#Comparison_Of_Sort_Keys_Table However [the conformance tests](https://www.unicode.org/Public/UCA/10.0.0/CollationTest.html) include in (non-normative) comments "a representation of the sort key" always ending with "|]" where the vertical bar stands for "the ZERO separator". Do not append a final unnecessary level separator.
|
@lucafavatella thank you! I will get to all this later in the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #17 (comment)
this PR rebases the
settingsbranch on masterincluding settings normalization and strength (each with unit tests)
and keeping out backwards - for lack of tests.