Add stream digest #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toml serialization implementation does not handle u64 data types, yaml does, and it also handles u128. Signed-off-by: Tony Asleson <tasleson@redhat.com>
Today the only way you have to check if a stream is correct is by comparing the stream with the device or file that the stream orginated from. This change adds a blake2 512bit digest to the stream config.toml. This can be used to validate what we unpack matches what we packed. This change also adds a "validate" command with a sub command of stream. Note: This change only applies to files or thick devices. Delta or thin functionality needs to yet be included. The digest in the config.yaml matches the output of b2sum, to make it easier to validate that blk-archive is calculating the digest correctly, eg. # b2sum /dev/sdb Matches what we have in the config.yaml for an archive of the same device. Signed-off-by: Tony Asleson <tasleson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the only way you have to check if a stream is correct is by
comparing the stream with the device or file that the stream
orginated from. This change adds a blake2 512bit digest to the
stream config.toml. This can be used to validate what we unpack
matches what we packed. This change also adds a "validate" command
with a sub command of stream.
Note: This change only applies to files or thick devices. Delta or
thin functionality needs to yet be included.
The digest in the config.yaml matches the output of b2sum, to make
it easier to validate that blk-archive is calculating the digest
correctly, eg.
# b2sum /dev/sdbMatches what we have in the config.yaml for an archive of the same
device.