fix minor issues with aem-universal-editor-service

juan-ayala · Sep 13, 2024 · ac27620 · ac27620
1 parent 0604ea7
commit ac27620
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/src/aem-universal-editor-service/bin/start-ues b/src/aem-universal-editor-service/bin/start-ues
@@ -31,6 +31,9 @@ if [ ! -f "${AEM_UES_FEATURE_DIR}/universal-editor-service.cjs" ]; then
 fi
 
 cd ${AEM_UES_FEATURE_DIR}
+
+source ${NVM_DIR}/nvm.sh
 nvm install
 nvm use
+
 node universal-editor-service.cjs
diff --git a/src/aem-universal-editor-service/devcontainer-feature.json b/src/aem-universal-editor-service/devcontainer-feature.json
@@ -1,6 +1,6 @@
 {
     "id": "aem-universal-editor-service",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "name": "Adobe Experience Manager Universal Editor Service",
     "description": "Setup the AEM Universal Editor Service for local development.",
     "options": {

diff --git a/src/aem-universal-editor-service/install.sh b/src/aem-universal-editor-service/install.sh
@@ -19,6 +19,9 @@ echo "20" > "${AEM_UES_FEATURE_DIR}/.nvmrc"
 # create ssl cert and private key
 openssl req -newkey rsa:2048 -nodes -keyout "${AEM_UES_FEATURE_DIR}/key.pem" \
         -x509 -days 365 -out "${AEM_UES_FEATURE_DIR}/certificate.pem" -subj '/CN=localhost'
+# and allow remote user to read private key
+chgrp ${_REMOTE_USER} "${AEM_UES_FEATURE_DIR}/key.pem"
+chmod g+r "${AEM_UES_FEATURE_DIR}/key.pem"
 
 # create .env file
 envfile="${AEM_UES_FEATURE_DIR}/.env"

diff --git a/test/aem-universal-editor-service/test.sh b/test/aem-universal-editor-service/test.sh
@@ -28,8 +28,10 @@ check "start-ues is +x" \
 # Check config files created
 check "created .nvmrc" \
     [ -f "${AEM_UES_FEATURE_DIR}/.nvmrc" ]
-check "created key" \
-    [ -f "${AEM_UES_FEATURE_DIR}/key.pem" ]
+check "can read key" \
+    stat -c '%a' "${AEM_UES_FEATURE_DIR}/key.pem" | grep 640
+check "key group set to remote user" \
+    stat -c '%G' "${AEM_UES_FEATURE_DIR}/key.pem" | grep "${_REMOTE_USER}"
 check "created certificate" \
     [ -f "${AEM_UES_FEATURE_DIR}/certificate.pem" ]
 check "created .env" \