Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the current tab/pane, rather than closing and creating new #31

Open
profucius opened this issue Jan 13, 2023 · 1 comment
Open

Comments

@profucius
Copy link

profucius commented Jan 13, 2023

Great plugin you've made @juliang22 ! I hope you're considering maintenance on it going forward (I see you've been inactive on this repo for 6 months)

I have just a quick request which would greatly improve my experience of using the plugin.

Currently, when opening a video into Timestamp Notes, it opens a new tab in a separate pane over on the right-hand sidebar. Even if I already had a Timestamp Notes tab open, and had moved it to another pane (which matches my workflow), opening a new Youtube video via the timestamp-url block, it always closes that current tab and opens a new one on the right-hand sidebar again.

Would you please change this functionality so that if a Timestamp Notes tab is already open, it reuses that. This would be so great.

Thank you!

@profucius
Copy link
Author

profucius commented Jan 13, 2023

From just a little bit of code sleuthing I did, although I am not proficient in javascript at all, I think this is the section in your main.js file that starts handling the creation of the Timestamp Notes tab.

Line 30045: this.registerMarkdownCodeBlockProcessor("timestamp-url", (source, el, ctx) => {

If you do not have the time on your hands at the moment to implement this feature and do testing for an official release, I am happy to try modifying the code locally on my machine, according to your guidance. I am proficient enough in general syntax of code to be able to implement and test any suggestions you make. I can then let you know if it worked, and then perhaps you can update your main branch to incorporate the feature.

zuluwi added a commit to zuluwi/ObsidianTimestampNotes that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant