Skip to content

Commit

Permalink
Upgrade detekt (#15)
Browse files Browse the repository at this point in the history
* Upgrade detekt

* Add jitpack badge
  • Loading branch information
hbmartin authored Jul 31, 2023
1 parent 99ed640 commit f22244f
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 7 deletions.
1 change: 1 addition & 0 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[![Android CI](https://github.com/jump-sdk/jetpack_compose_country_code_picker_emoji/actions/workflows/android.yml/badge.svg)](https://github.com/jump-sdk/jetpack_compose_country_code_picker_emoji/actions/workflows/android.yml)
[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=jump-sdk_jetpack_compose_country_code_picker_emoji&metric=sqale_rating)](https://sonarcloud.io/summary/new_code?id=jump-sdk_jetpack_compose_country_code_picker_emoji)
[![Jitpack](https://jitpack.io/v/jump-sdk/jetpack_compose_country_code_picker_emoji.svg)](https://jitpack.io/#jump-sdk/jetpack_compose_country_code_picker_emoji)

* 😍 Emoji flag icons - beautiful and minimizes library size
* 🤔 Country numbers hints (option to disable)
Expand Down Expand Up @@ -81,7 +82,7 @@ Step 2. Add the dependency

```kotlin
dependencies {
implementation("com.github.jump-sdk:jetpack_compose_country_code_picker_emoji:2.0.7")
implementation("com.github.jump-sdk:jetpack_compose_country_code_picker_emoji:2.0.8")
}
```

Expand Down
3 changes: 2 additions & 1 deletion ccp/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,11 @@ dependencies {
implementation(libs.compose.tooling.preview)

detektPlugins("ru.kode:detekt-rules-compose:1.3.0")
detektPlugins("io.nlopez.compose.rules:detekt:0.1.12")
detektPlugins("io.nlopez.compose.rules:detekt:0.1.13")
detektPlugins("io.gitlab.arturbosch.detekt:detekt-rules-libraries:${libs.versions.detekt.get()}")
detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:${libs.versions.detekt.get()}")
detektPlugins("com.braisgabin.detekt:kotlin-compiler-wrapper:0.0.4")
detektPlugins("com.github.hbmartin:hbmartin-detekt-rules:0.0.9")
}

detekt {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class PhoneNumberTransformation(countryCode: String) : VisualTransformation {
)
}

@Suppress("AvoidMutableCollections", "AvoidVarsExceptWithDelegate")
private fun reformat(s: CharSequence, cursor: Int): Transformation {
phoneNumberFormatter.clear()

Expand Down
2 changes: 0 additions & 2 deletions detekt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -654,8 +654,6 @@ style:
OptionalUnit:
active: true
excludes: ['**/build/**']
OptionalWhenBraces:
active: true
PreferToOverPairSyntax:
active: true
ProtectedMemberInFinalClass:
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ compileSdk = "34"
# Dependencies
android-gradle-plugin = "8.1.0"
gradle-versions = "0.47.0"
detekt = "1.23.0"
detekt = "1.23.1"

accompanist = "0.31.5-beta"
androidx-activity-compose = "1.7.2"
Expand Down
1 change: 1 addition & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ dependencyResolutionManagement {
repositories {
google()
mavenCentral()
maven("https://jitpack.io")
}
}
rootProject.name = "CountryCodePicker"
Expand Down

0 comments on commit f22244f

Please sign in to comment.