Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ClearIcon color logic #52

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Improve ClearIcon color logic #52

merged 2 commits into from
Nov 15, 2023

Conversation

PierreNicol
Copy link
Contributor

Fix a small bug on the ClearIcon color.

When showError is set to false, ClearIcon doesn't use this value and still display error color.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hbmartin hbmartin merged commit e245585 into jump-sdk:master Nov 15, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarsanchezv omarsanchezv Awaiting requested review from omarsanchezv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierreNicol @hbmartin