Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ensemble load error #9

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix: fix ensemble load error #9

merged 3 commits into from
Mar 6, 2024

Conversation

jung235
Copy link
Owner

@jung235 jung235 commented Mar 6, 2024

To make Ensemble picklable, the second element of __reduce__ should be a tuple.

@jung235 jung235 self-assigned this Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.71%. Comparing base (22e496a) to head (ce90c83).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   46.28%   56.71%   +10.43%     
===========================================
  Files          30       32        +2     
  Lines         955     1035       +80     
===========================================
+ Hits          442      587      +145     
+ Misses        513      448       -65     
Files Coverage Δ
pydiffuser/tracer/ensemble.py 42.85% <0.00%> (+8.62%) ⬆️
pydiffuser/utils/config.py 67.44% <33.33%> (+12.17%) ⬆️

... and 6 files with indirect coverage changes

@jung235 jung235 merged commit db21564 into main Mar 6, 2024
7 checks passed
@jung235 jung235 deleted the hotfix/fix-ens-load branch March 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants