-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update absinthe dependency #41
base: master
Are you sure you want to change the base?
Conversation
@gabrielpra1 @jotaviobiondo any feedback on this? Is this still being actively developed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @churcho, thanks for the contribution! Sorry for the delay, we missed this PR.. Left some discussions.
version: "1.3.2", | ||
elixir: "~> 1.8", | ||
version: "1.3.3", | ||
elixir: "~> 1.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import Config
was introduced in Elixir 1.9, do we need to restrict the minimum acceptable version so much?
Ideally we would keep the minimum version that is still supported here, so that it doesn't break for anyone without needing it.
|
||
config :logger, level: :debug | ||
|
||
import_config "#{Mix.env()}.exs" | ||
for config <- "../apps/*/config/config.exs" |> Path.expand(__DIR__) |> Path.wildcard() do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for umbrella apps, right? Not sure if it would work for everyone.
But we actually don't need any configs in this lib, I think we could delete the entire config/
directory, which would simplify it and prevent any warnings in the future
{:credo, "~> 1.5.0", only: [:dev, :test], runtime: false}, | ||
{:absinthe, "~> 1.4.0 or ~> 1.5.4 or ~> 1.6.0"}, | ||
{:credo, "~> 1.6.0", only: [:dev, :test], runtime: false}, | ||
{:absinthe, "~> 1.5.4 or ~> 1.6.0 or ~> 1.7"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar question to the comment above about the elixir version, do we need to drop support for absinthe 1.4? If it still works, better to keep it
Bumped the elixir version and updated the config files because of build warnings for the latest Elixir version.
I've bumped the Absinthe version and also removed the dependency provision for the earlier 1.4 version.
The rest of the module bumps were necessitated by the build warnings. All tests are passing.