Add virtual thread support #3443
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
requested changes
Sep 1, 2023
...org/junit/platform/engine/support/hierarchical/VirtualParallelExecutionIntegrationTests.java
Outdated
Show resolved
Hide resolved
...org/junit/platform/engine/support/hierarchical/VirtualParallelExecutionIntegrationTests.java
Show resolved
Hide resolved
gradle/plugins/common/src/main/kotlin/junitbuild/exec/RunConsoleLauncher.kt
Show resolved
Hide resolved
Co-authored-by: Marc Philipp <mail@marcphilipp.de>
marcphilipp
requested changes
Sep 10, 2023
| @@ -124,6 +124,8 @@ public final class Constants { | |||
| @API(status = STABLE, since = "5.10") | |||
| public static final String PARALLEL_EXECUTION_ENABLED_PROPERTY_NAME = JupiterConfiguration.PARALLEL_EXECUTION_ENABLED_PROPERTY_NAME; | |||
|
|
|||
| public static final String PARALLEL_EXECUTOR_PROPERTY_NAME = JupiterConfiguration.PARALLEL_EXECUTOR_PROPERTY_NAME; | |||
There was a problem hiding this comment.
❌ needs an @API annotation and Javadoc
| @@ -216,7 +216,7 @@ public ParallelExecutionConfiguration createConfiguration(ConfigurationParameter | |||
| */ | |||
| public static final String CONFIG_CUSTOM_CLASS_PROPERTY_NAME = "custom.class"; | |||
|
|
|||
| static ParallelExecutionConfigurationStrategy getStrategy(ConfigurationParameters configurationParameters) { | |||
| public static ParallelExecutionConfigurationStrategy getStrategy(ConfigurationParameters configurationParameters) { | |||
There was a problem hiding this comment.
❌ Doesn't need to be public
| @@ -208,10 +208,13 @@ public void compute() { | |||
|
|
|||
| } | |||
|
|
|||
| static class WorkerThreadFactory implements ForkJoinPool.ForkJoinWorkerThreadFactory { | |||
| public static class WorkerThreadFactory implements ForkJoinPool.ForkJoinWorkerThreadFactory { | |||
There was a problem hiding this comment.
❌ Doesn't need to be public
|
|
||
| private final ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); | ||
|
|
||
| public WorkerThreadFactory() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3442
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations