⌨️ Do not export code block options when undefined (#1721)

Co-authored-by: Franklin Koch <franklinwkoch@gmail.com>
jupyter-book · Jan 6, 2025 · 3950dca · 3950dca
1 parent 0d82810
commit 3950dca
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/.changeset/wicked-gifts-walk.md b/.changeset/wicked-gifts-walk.md
@@ -0,0 +1,5 @@
+---
+"myst-to-md": patch
+---
+
+Do not have code block options exported when they are null
diff --git a/packages/myst-to-md/src/directives.ts b/packages/myst-to-md/src/directives.ts
@@ -98,7 +98,9 @@ const CODE_BLOCK_KEYS = [
  * non-directive code fence.
  */
 function code(node: any, _: Parent, state: NestedState, info: Info): string {
-  const nodeCodeBlockKeys = Object.keys(node).filter((k) => CODE_BLOCK_KEYS.includes(k));
+  const nodeCodeBlockKeys = Object.entries(node).filter(
+    ([k, v]) => CODE_BLOCK_KEYS.includes(k) && v != null,
+  );
   if (!nodeCodeBlockKeys.length) {
     return defaultHandlers.code(node, _, state, info);
   }

diff --git a/packages/myst-to-md/tests/directives.yml b/packages/myst-to-md/tests/directives.yml
@@ -217,6 +217,26 @@ cases:
       :lineno-start: 2
       :meta: highlight-line="2"
 
+      5+5
+      print("hello world")
+       ```
+       ```
+      ````
+  - title: code directive - null options
+    mdast:
+      type: root
+      children:
+        - type: code
+          lang: python
+          meta: null
+          showLineNumbers: null
+          value: |-
+            5+5
+            print("hello world")
+             ```
+             ```
+    markdown: |-
+      ````python
       5+5
       print("hello world")
        ```