incorporate suggestions from review

jupyter-widgets · Apr 12, 2024 · cbc5bfa · cbc5bfa
1 parent 64a952c
commit cbc5bfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/python/jupyter_leaflet/src/Map.ts b/python/jupyter_leaflet/src/Map.ts
@@ -235,6 +235,8 @@ export class LeafletMapView extends LeafletDOMWidgetView {
     const view = await this.create_child_view<LeafletControlView>(child_model, {
       map_view: this,
     });
+    // Work around for Geoman creating and adding its own toolbar
+    // TODO: remove the special case
     if (
       view instanceof LeafletGeomanDrawControlView &&
       !child_model.get('hide_controls')

diff --git a/python/jupyter_leaflet/src/controls/GeomanDrawControl.ts b/python/jupyter_leaflet/src/controls/GeomanDrawControl.ts
@@ -322,6 +322,7 @@ export class LeafletGeomanDrawControlView extends LeafletControlView {
   }
 
   remove() {
+    this.map_view.obj.pm.removeControls();
     this.map_view.obj.removeLayer(this.feature_group);
     this.map_view.obj.off('pm:create');
     this.map_view.obj.off('pm:remove');