Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLite demo errors on ipyleaflet.readthedocs.io #1127

Closed
psychemedia opened this issue Jul 24, 2023 · 10 comments
Closed

JupyterLite demo errors on ipyleaflet.readthedocs.io #1127

psychemedia opened this issue Jul 24, 2023 · 10 comments

Comments

@psychemedia
Copy link

Trying to run the online demo at https://ipyleaflet.readthedocs.io/en/latest/index.html raises an error.

image
@psychemedia psychemedia changed the title JupyterLite demo errors on readthedocs JupyterLite demo errors on ipyleaflet.readthedocs.io Jul 24, 2023
@martinRenou
Copy link
Member

We should probably switch to xeus-python in the jupyterlite demo

@drf5n
Copy link
Contributor

drf5n commented Aug 17, 2023

This project's main README.md refers from https://github.com/jupyter-widgets/ipyleaflet#documentation directly to the broken https://ipyleaflet.readthedocs.io/en/latest/ page.

If the fix is still in the planning stages, and may continue for another three weeks, at least the https://ipyleaflet.readthedocs.io/en/latest/ front page should have a note or point here to issue #1127 for status updates.

@rdhyee
Copy link

rdhyee commented Oct 27, 2023

FWIW, I was just trying to learn about ipyleaflet today and saw the error under discussion here. Wondering whether this is an issue that is a good one for someone new to the project to try to fix.

@maartenbreddels
Copy link
Member

It has been broken for quite a while, should we remove it? It does not give a good impression now.

@drf5n
Copy link
Contributor

drf5n commented Nov 21, 2023

Where is the code that makes that page? Is it near https://github.com/jupyter-widgets/ipyleaflet/blob/master/docs/source/index.rst

This should be a basic use-case for ipyleaflet and should be repaired rather than removed.

@martinRenou
Copy link
Member

It should be more stable now

@drf5n
Copy link
Contributor

drf5n commented Nov 30, 2023

I get this after a click and two shift-returns:

image ...or in text form:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
File /lib/python3.10/site-packages/IPython/__init__.py:44, in patch_asyncio.<locals>.asyncio_call(self, coro)
     41     task.add_done_callback(done_cb)
     43 raw_js_py_callback = pyjs.JsValue(py_callback)
---> 44 js_py_callback = raw_js_py_callback['__usafe_void_val_val__'].bind(raw_js_py_callback)
     45 js_promise = pyjs.js.Promise.new(js_py_callback)
     47 pyjs.js.globalThis.toplevel_promise = js_promise

AttributeError: has no attribute/key 

@martinRenou
Copy link
Member

You're hitting some caching. Can you try opening the documentation page from a private window?

The Notebook should now use the jupyterlite-xeus-python kernel which does not provide piplite. ipyleaflet should be pre-installed in this kernel.

@rdhyee
Copy link

rdhyee commented Nov 30, 2023

I can confirm that when I go to https://ipyleaflet.readthedocs.io/en/latest/index.html in a private window, the demo is now working for me.

@martinRenou
Copy link
Member

Nice!

Browser caching is known to go in your way when using JupyterLite. Cleaning all data for that webpage or opening from a private windows should prevent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants