Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce leaflet-geoman as an alternative to leaflet-draw #1181

Merged
merged 9 commits into from
Apr 23, 2024
Merged

feat: introduce leaflet-geoman as an alternative to leaflet-draw #1181

merged 9 commits into from
Apr 23, 2024

Commits on Apr 12, 2024

  1. feat: move from leaflet-draw to leaflet-geoman

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b3de415 View commit details
    Browse the repository at this point in the history

  2. refactor: improved backwards compatibility

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7453fd8 View commit details
    Browse the repository at this point in the history

  3. docs: document GeomanDrawControl

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    70768d5 View commit details
    Browse the repository at this point in the history

  4. implement fixes to issues found in review

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8ad384f View commit details
    Browse the repository at this point in the history

  5. refactor: retain old DrawControl for migration period

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    90cc595 View commit details
    Browse the repository at this point in the history

  6. update reference images

    @iisakkirotko @martinRenou
    iisakkirotko authored and martinRenou committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    64a952c View commit details
    Browse the repository at this point in the history

  7. incorporate suggestions from review

    @iisakkirotko
    iisakkirotko committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cbc5bfa View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
    @iisakkirotko @maartenbreddels
    iisakkirotko and maartenbreddels committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0c730e0 View commit details
    Browse the repository at this point in the history

  2. fix: correct default options 

    previously `circlemarker` incorrectly defaulted to using `markerStyle`, while it isn't a leaflet marker layer. Moreover, polyline and polygon would use the old (`shapeOptions`) by default even with geoman, where it should be `pathOptions`. This was fixed by the compatibility layer, but this way the defaults are clearer.
    @iisakkirotko
    iisakkirotko committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ee298f6 View commit details
    Browse the repository at this point in the history